Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fw): clean up and extend test_fixtures framework tests #456

Open
spencer-tb opened this issue Feb 26, 2024 · 0 comments
Open

chore(fw): clean up and extend test_fixtures framework tests #456

spencer-tb opened this issue Feb 26, 2024 · 0 comments

Comments

@spencer-tb
Copy link
Collaborator

src/ethereum_test_tools/tests/test_filling/test_fixtures.py (link) is quite messy, as its written upon the tests that existed within the initial repo.

These tests can be improved dramatically to distinctly test each solc version and fork, all tests should generate each test type: state_test, blockchain_test and assert that the blockchain version of the state_test fixture matches that of the blockchain_test fixture.

The refactor should make it easy for us add tests for new forks in the future. I.e simply adding a fork name and a fixture file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant