Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between "Accounts" and "Transactions" doc pages #12897

Open
1 of 2 tasks
ckoopmann opened this issue May 3, 2024 · 2 comments
Open
1 of 2 tasks

Inconsistency between "Accounts" and "Transactions" doc pages #12897

ckoopmann opened this issue May 3, 2024 · 2 comments
Assignees
Labels
bug 🐛 Something isn't working low priority This has a low priority

Comments

@ckoopmann
Copy link

ckoopmann commented May 3, 2024

Describe the bug

On the documentation for "accounts" it says:

An Ethereum account is an entity with an ether (ETH) balance that can send transactions on Ethereum. Accounts can be user-controlled or deployed as smart contracts.

This sentence implies that smart contract accounts can send "transactions", which contradicts the definition of "transaction" on the corresponding doc page:

An Ethereum transaction refers to an action initiated by an externally-owned account, in other words an account managed by a human, not a contract.

It seems the term "transaction" is used incorrectly on the accounts page so I'd suggest replacing it with an alternative such as "call" or "message" .

To reproduce

  1. Read doc page regarding accounts
  2. Read doc page regarding transactions

Expected behavior

Terms should be used consistently across the documentation pages.

Screenshots

image
image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@ckoopmann ckoopmann added the bug 🐛 Something isn't working label May 3, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label May 3, 2024
@corwintines
Copy link
Member

Thanks @ckoopmann. I agree, this could use some updates. I think what is on the accounts page is correct from what you shared. I think the transactions page. Transactions can be submitted by both smart contracts and EOA's, so this should be updated.

I see you put you are interested. I will assign this to you :) Let me know if you need anything.

@wackerow
Copy link
Member

wackerow commented Jun 6, 2024

Hey @ckoopmann! Just checking in, any update here? Any way we can help?

@wackerow wackerow added low priority This has a low priority and removed needs triage 📥 This issue needs triaged before being worked on labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working low priority This has a low priority
Projects
None yet
Development

No branches or pull requests

3 participants