Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyrlp version #111

Closed
ChihChengLiang opened this issue Apr 26, 2018 · 10 comments
Closed

Update pyrlp version #111

ChihChengLiang opened this issue Apr 26, 2018 · 10 comments

Comments

@ChihChengLiang
Copy link
Contributor

Issue

Recently the pyrlp upgraded to 1.0.0-beta and introduced some breaking changes, such as removing encode_hex and decode_hex functions ethereum/pyrlp#55 .

Suggested implementation

@hrishikeshio
Copy link
Contributor

hrishikeshio commented May 3, 2018

There are dependency issues ethereum/pydevp2p#95

casper depends on pydevp2p which requires rlp<1. This is because devp2p is python2 and python3 compatible but rlp>1 and eth_utils are not compatible with python2.

@djrtwo
Copy link
Contributor

djrtwo commented May 7, 2018

Thanks for looking into this!

@djrtwo
Copy link
Contributor

djrtwo commented May 9, 2018

Any update on this one?

@hrishikeshio
Copy link
Contributor

hrishikeshio commented May 9, 2018

@djrtwo. It's blocked. How do we proceed? We have to make pydevp2p python 3 only... Is that ok?
Or else we have to pin pydevp2p dependency to rlp<1

@ChihChengLiang
Copy link
Contributor Author

ah ... sorry @hrishikeshio , most of the packages in requirements.txt are not required now. The pydevp2p was used by a casper daemon that is removed recently. I'll clean up the requirements.txt and you should able to work on this soon.

@djrtwo
Copy link
Contributor

djrtwo commented May 10, 2018

should be unblocked @hrishikeshio

@hrishikeshio
Copy link
Contributor

Thanks guys. But now it seems pyethereum upgraded to rlp 1 only in the very recent commit. and the build is failing. ethereum/pyethereum@6c7cf77

Created this issue.
ethereum/pyethereum#876

@hrishikeshio
Copy link
Contributor

Now its blocked because of this ethereum/pyethereum#879

@djrtwo
Copy link
Contributor

djrtwo commented May 23, 2018

This is going to be fixed in #150 becuase I am getting rid of the pyethereum dependency. I'll take it from here. Thanks for your help digging @hrishikeshio

@djrtwo
Copy link
Contributor

djrtwo commented May 25, 2018

addressed in #150

@djrtwo djrtwo closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants