Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Incorrect retry logic in OverlayDB::commit() #5883

Open
tzubcic-tolar opened this issue Jan 31, 2020 · 0 comments
Open

Incorrect retry logic in OverlayDB::commit() #5883

tzubcic-tolar opened this issue Jan 31, 2020 · 0 comments

Comments

@tzubcic-tolar
Copy link

m_db->commit(std::move(writeBatch));

Since writeBatch (which is a unique_ptr) is moved, if m_db->commit() throws, the next retry will attempt to call it with a unique_ptr that has been moved from.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant