Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assets redirect #243

Open
Divide-By-0 opened this issue Feb 7, 2024 · 3 comments
Open

Fix assets redirect #243

Divide-By-0 opened this issue Feb 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Divide-By-0
Copy link
Contributor

Divide-By-0 commented Feb 7, 2024 •
edited

Pull Request

#242

What happened?

I make assets/erc-#/. Then I hyperlink to text in my docs. It errors with HTML Proofer since file doesn't exist.

In this commit, we fix it by changing erc-# to eip-#, even though that folder doesn't exist.

On compilation, I think assets/erc-# should automatically ln/symlink to assets/eip-# so that behavior is always intuitive.

Relevant log output

  • At ./_site/EIPS/eip-7524.html:252:
    internally linking to ../assets/erc-7524/sec2-v2.pdf, which does not exist

  • At ./_site/EIPS/eip-7524.html:281:
    internally linking to ../assets/erc-7524/sec1-v2.pdf, which does not exist

I get this issue from HTMLProofer when hyperlinking intuitively for the way it compiles in VSCode.
@Divide-By-0 Divide-By-0 added the bug Something isn't working label Feb 7, 2024
@Divide-By-0 Divide-By-0 mentioned this issue Feb 7, 2024
Closed
@github-actions GitHub Actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@Divide-By-0
Copy link
Contributor Author

This seems like a small thing that would complete the eip to erc migration, and at the very least should be in the docs.

@github-actions github-actions bot removed the w-stale label May 20, 2024
@poojaranjan poojaranjan mentioned this issue May 22, 2024
Closed
14 tasks
@SamWilsn
Copy link
Collaborator

Agreed! @lightclient how hard is this to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Divide-By-0 @SamWilsn