Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo a little off #15

Open
274188A opened this issue Oct 15, 2022 · 9 comments
Open

Demo a little off #15

274188A opened this issue Oct 15, 2022 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@274188A
Copy link

274188A commented Oct 15, 2022

image

@erossini
Copy link
Owner

Oh, let me check

@erossini
Copy link
Owner

So, I think this is an issue with Chart.js. I opened a bug on their project. All the other graphs are ok except for the line graph.

@macias
Copy link

macias commented Oct 19, 2022

@erossini I guess your last changes within Chart.razor was about this problem? However it led only to bigger problems.

I use firefox and before when running demo I had big gap under the chart. Now, after this change I have chart overlapping the code, but in my own app the chart resizes on entire screen.

Locally I can remove those changes, but I would say until there is really rock solid solution to remove those changes from your code as well (i.e. officially so to speak).

@erossini
Copy link
Owner

I'm not sure this problem is something related to Chart.razor because if you open the HTML, you can see the height of the chart-container is rewritten for the canvas by Chart.js but only when you ask for a line chart.

I don't know if you have the same problem or not.

@macias
Copy link

macias commented Oct 19, 2022

I am using scatter plot in my app.

As for my app I found the culprit -- in your last changes you added css class with display: inline-block. This is causing chart to go over entire screen.

I would say this and setting width to 100% would be better removed. Let user decide via Class property, it is fully customizable after all.

@erossini
Copy link
Owner

But this happens only with the line graph. For example, with Firefox

image

the line graph is all over the place, but other graphs are ok.

image

@erossini
Copy link
Owner

I removed the display in the CSS

@erossini erossini added the bug Something isn't working label Oct 19, 2022
@macias
Copy link

macias commented Oct 19, 2022

Yes, the demo looks off, but I don't know why (so far). My point was that fix should of course improve the demo, but behave predictably in other apps as well.

@erossini
Copy link
Owner

PS: I added few new graphs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants