Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async load browser-solc #1

Open
marcusmolchany opened this issue Jan 12, 2018 · 2 comments
Open

async load browser-solc #1

marcusmolchany opened this issue Jan 12, 2018 · 2 comments

Comments

@marcusmolchany
Copy link

Hey! I'd like to asynchronously load browser-solc on a webpage. Right now for non-IE browsers, the main handler is listening for DOMContentLoaded before it attaches BrowserSolc to window (here). However, if this script tag is asynchronously loaded and arrives after DOMContentLoaded it will never execute.

I'll propose a PR for this change.
@ericxtang
Copy link
Owner

Hi @marcusmolchany - late response here. Are you still interested in putting in a PR?

@marcusmolchany
Copy link
Author

hey @ericxtang, i don't have time to make a pr for this right now. tag me if there's discussion or a pr for it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericxtang @marcusmolchany