-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DeviceType #1125
Comments
I've never understood what you declare as "device". Sometimes only "ems-devices", like in telnet "show devices". Bt the mqtt publishes the values with topic "device_data". API uses "/api/device/...", etc.
If you want to remove scheduler from this scheme, also remove system, shower, sensors. But please describe the different endpoints for mqtt, api, etc., because it will get confusing. |
The framework is based on a design that I had created 2 years ago for v3 where I wanted to make EMS-ESP extendable and support multiple devices. The shower, system etc came afterwards as a bit of hack and I never anticipated the adoption of the project. The code needs a good re-factor. Something for v4 if we get there and I'm still around. |
The design principals only mention "EMS-devices", i think "devices" is umbrella term for "EMS-devices" and "other-devices". |
Is it possible to differ between:
and
Then it would be easier and more flexible to assign messages from the physical- to the logical-devices.
Most of that messages from EMS-devices are unique and assigned to logical parts of the system but not close linked to the hardware device-id. |
Scheduler is listed as device because commands/api check for valid device from this list, system, analog, dallas are also no ems-devices, but devices for api/command.
Before fix and after fix:
Originally posted by @MichaelDvP in #1124 (comment)
The text was updated successfully, but these errors were encountered: