Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gif support #4620

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Gif support #4620

wants to merge 15 commits into from
+253 −11

Conversation

JustFrederik
Copy link

@JustFrederik JustFrederik commented Jun 5, 2024 •
edited by emilk

@YgorSouza
Copy link
Contributor

Could add Closes #4489 to the description so we don't forget to close the issue afterward.

emilk
emilk reviewed Jun 6, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very promising! A a great test gif too :)

crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui_extras/src/loaders/gif_loader.rs Outdated Show resolved Hide resolved
crates/egui_extras/src/loaders/gif_loader.rs Outdated Show resolved Hide resolved
crates/egui_extras/src/loaders/gif_loader.rs Outdated Show resolved Hide resolved
@JustFrederik
Copy link
Author

@emilk every requested change is implemented. I didn't test the file_loader, but it should behave the exactly like the ehttp loader which works.

@JustFrederik JustFrederik requested a review from emilk June 6, 2024 16:32
emilk
emilk requested changes Jun 7, 2024
View reviewed changes
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
crates/egui_extras/src/loaders/ehttp_loader.rs Outdated Show resolved Hide resolved
crates/egui_extras/src/loaders/gif_loader.rs Outdated Show resolved Hide resolved
crates/egui_extras/src/loaders/gif_loader.rs Outdated Show resolved Hide resolved
@JustFrederik JustFrederik requested a review from emilk June 7, 2024 11:48
@JustFrederik
Copy link
Author

@emilk is this ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YgorSouza YgorSouza YgorSouza left review comments

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gif Support
3 participants
@JustFrederik @YgorSouza @emilk