-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SidePanel
frame leaks into BottomPanel
#4475
Milestone
Comments
abey79
changed the title
May 7, 2024
SidePanel
frame leaks into `BottomPanelSidePanel
frame leaks into BottomPanel
This was referenced May 7, 2024
An obvious workaround is to wrap the entire content of the |
abey79
added a commit
to rerun-io/rerun
that referenced
this issue
May 8, 2024
### What - Fixes #6227 A workaround for emilk/egui#4475 was needed that will need to be cleaned: - #6256 **NOTE**: chained to #6248 to minimise conflicts. Note that this doesn't _entirely_ fix the visual glitch, but makes it much less visible. Now the time panel must be disproportionately be stretched _and_ one must hover the separator: <img width="445" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/d66ccccb-2a22-4d00-bb8e-7c020c806928"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6255?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6255?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6255) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
May be related to #4349 |
I think we need two things to solve this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider this code:
The left panel badly bleed into the bottom panel:
Fix attempt (1) consist of setting a clip rect before the panel code, and doesn't appear to make any change.
Fix attempt (2) does clip the left panel's content correctly, but not it's fill:
This is the root cause of rerun-io/rerun#6227
The text was updated successfully, but these errors were encountered: