Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Followup]: heap allocation crashes in v8/node tests #42125

Open
3 tasks done
VerteDinde opened this issue May 10, 2024 · 0 comments
Open
3 tasks done

[Upgrade Followup]: heap allocation crashes in v8/node tests #42125

VerteDinde opened this issue May 10, 2024 · 0 comments
Labels
31-x-y upgrade-follow-up Stuff left to do after a Chromium upgrade.

Comments

@VerteDinde
Copy link
Member

VerteDinde commented May 10, 2024

Preflight Checklist

Problem Description

In a recent Chromium roll (#41868), v8 made several upstream changes to how line endings are handled in heap snapshots. These changes caused 8-9 consistent crashes in our downstream Linux Node tests.

V8 tracking bug: https://issues.chromium.org/issues/42204564

Proposed Solution

To keep the roll moving a patch was applied, but this isn't a permanent solution: 8ecca61 We should address the root issue of the heap allocation crashes - they may also be fixed in future upstream changes, but those changes need be applied and the patch removed.

Additional Information

Chrome Roll: #41868
V8 tracking bug: https://issues.chromium.org/issues/42204564

@VerteDinde VerteDinde added upgrade-follow-up Stuff left to do after a Chromium upgrade. 31-x-y labels May 10, 2024
@VerteDinde VerteDinde changed the title [Upgrade Followup]: [Upgrade Followup]: heap allocation crashes in v8/node tests May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
31-x-y upgrade-follow-up Stuff left to do after a Chromium upgrade.
Projects
Status: 👍 Does Not Block Stable
Development

No branches or pull requests

1 participant