feat: Allow WebContentsView to accept webContents object. #42086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
requested changes
May 10, 2024
| expect(webContentsView.webContents).to.eq(wc); | ||
| expect(webContents.getAllWebContents().length).to.equal(currentWebContentsCount + 1, 'expected only single webcontents to be created'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Please also test what happens if you create a WebContentsView with a WebContents that's already attached somewhere else (either a BrowserWindow's WebContents or another WebContentsView's WebContents).
There was a problem hiding this comment.
I've added the check for owner window when creating WebContentsView. Please let me know if there is a better way to determine whether WebContents is already attached to something.
khalwa
force-pushed
the
webContentsView-accepting-webcontents-option
branch
from
07cc3ac
to
bcf4199
Compare
electron-cation
bot
added
api-review/requested 🗳
and removed
new-pr 🌱
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #42054.
This PR enables
WebContentsViewto accept existingwebContentsobject in order to be able to properly handle popups. This issue is described here: #42054.Checklist
npm testpassesRelease Notes
Notes: Extended
WebContentsViewto accept pre-existingwebContentsobject.