Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in DenseVectorFieldMapper.java and HistogramFieldMapper.java #108050

Closed
snurf198 opened this issue Apr 30, 2024 · 3 comments · Fixed by #108065 or #108804
Closed

Typo in DenseVectorFieldMapper.java and HistogramFieldMapper.java #108050

snurf198 opened this issue Apr 30, 2024 · 3 comments · Fixed by #108065 or #108804
Labels
>bug priority:normal A label for assessing bug priority to be used by ES engineers :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine

Comments

@snurf198
Copy link
Contributor

snurf198 commented Apr 30, 2024 •
edited

Elasticsearch Version

8.13.2

Installed Plugins

No response

Java Version

java 17.0.7 2023-04-18 LTS Java(TM) SE Runtime Environment (build 17.0.7+8-LTS-224) Java HotSpot(TM) 64-Bit Server VM (build 17.0.7+8-LTS-224, mixed mode, sharing)

OS Version

Darwin 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:11:05 PDT 2024; root:xnu-10063.101.17~1/RELEASE_X86_64 x86_64

Problem Description

in both

./server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java:1417
./x-pack/plugin/analytics/src/main/java/org/elasticsearch/xpack/analytics/mapper/HistogramFieldMapper.java:413

files, there is a typo.

+ "] doesn't not support indexing multiple values for the same field in the same document"
should be changed to
+ "] does not support indexing multiple values for the same field in the same document"

also, the corresponding test code should be changed.

Steps to Reproduce

.

Logs (if relevant)

No response
@snurf198 snurf198 added >bug needs:triage Requires assignment of a team area label labels Apr 30, 2024
@pxsalehi pxsalehi added the :Search/Mapping Index mappings, including merging and defining field types label Apr 30, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Apr 30, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Apr 30, 2024
@tteofili tteofili mentioned this issue Apr 30, 2024
Merged
@snurf198 snurf198 mentioned this issue Apr 30, 2024
Closed
@tteofili tteofili reopened this Apr 30, 2024
@snurf198 snurf198 mentioned this issue May 18, 2024
Merged
@javanna javanna added priority:normal A label for assessing bug priority to be used by ES engineers and removed :Search/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team labels Jun 6, 2024
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jun 6, 2024
@javanna javanna added :StorageEngine/Mapping The storage related side of mappings and removed needs:triage Requires assignment of a team area label labels Jun 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@javanna
Copy link
Member

javanna commented Jun 6, 2024

The Search side of this issue has been fixed, moved to storage engine for the fix on histogram field mapper, there's a PR that will get merged soon.

elasticsearchmachine pushed a commit that referenced this issue Jun 6, 2024
@snurf198
HFM typo fixed and test fixed (#108804)
2822fa4 
<!-- Thank you for your interest in and contributing to Elasticsearch!
There are a few simple things to check before submitting your pull
request that can help with the review process. You should delete these
items from your submission, but they are here to help bring them to your
attention. -->

Fix typo in HistogramFieldMapper  and fixed related test code

closes #108050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug priority:normal A label for assessing bug priority to be used by ES engineers :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine
Projects
None yet
Milestone
No milestone
5 participants
@tteofili @javanna @pxsalehi @snurf198 @elasticsearchmachine