Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion on official cli binary name #232

Open
jay-babu opened this issue Dec 8, 2022 · 9 comments
Open

Confusion on official cli binary name #232

jay-babu opened this issue Dec 8, 2022 · 9 comments

Comments

@jay-babu
Copy link

jay-babu commented Dec 8, 2022

Hello,

When this tool is installed, should the binary/cli tool be called editorconfig-checker or ec. Typically, shorthand names like ec are reserved for system tools such as ls, cat, etc.

When running

go install github.com/editorconfig-checker/editorconfig-checker/cmd/editorconfig-checker@latest, the binary name is editorconfig-checker. However, on the releases page, the binary is ec. This has sparked some discussions across a few plugins using this plugin:

jose-elias-alvarez/null-ls.nvim#1282

jay-babu/mason-null-ls.nvim#37

williamboman/mason.nvim#722

What should these plugins assume the binary to be called by default: editorconfig-checker or ec?

@jay-babu
Copy link
Author

jay-babu commented Dec 8, 2022

Note: I am a fan of editorconfig-checker, but don't let that change what it is supposed to be.

@jay-babu
Copy link
Author

@chalkygames123, would you be able to provide some guidance?

@chalkygames123
Copy link
Contributor

Nah, I'm not a maintainer of this project. But I'm a fan of editorconfig-checker too.

@jay-babu
Copy link
Author

@mstruebing, are you a maintainer? Would you be able to weigh in on this?

@mstruebing
Copy link
Member

So, my intention to add ec as a possible binary name was just because it is shorter and I'm lazy!
I did not really know about the convention of system tools.

Do you have a strong opinion if it should rather be ec or editorconfig-checker?

@chalkygames123 @jay-babu

I currently think it should be editorconfig-checker but I let your opinion count more than mine.

@jay-babu
Copy link
Author

jay-babu commented Jan 14, 2023

I would side with editorconfig-checker, based on the above convention. People usually alias if they want something shorter and can do so in their own dotfiles. It's a 1 line change for them.

@chalkygames123
Copy link
Contributor

Having an alias binary is okay, but having only that one is not a good idea, IMO.

@jay-babu
Copy link
Author

@mstruebing, can we close this issue with the acceptance of editorconfig-checker as the resolution?

@jemag
Copy link

jemag commented Feb 3, 2023

If truly the confusion is to be removed, then I think it would be important to standardize it across the board.

Currently the pacman install and the docker image use ec and the README is also consistently referring to ec. For those reasons, I actually thought that the official binary name was ec.

If editorconfig-checker is to be adopted instead, then it would be important to change all of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants