Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GCC warnings #104

Open
ikmsk10 opened this issue Jun 26, 2021 · 0 comments
Open

Prevent GCC warnings #104

ikmsk10 opened this issue Jun 26, 2021 · 0 comments

Comments

@ikmsk10
Copy link

ikmsk10 commented Jun 26, 2021

Some code of the fastcgipp has the following warnings:

../subprojects/fastcgi++/include/fastcgi++/protocol.hpp:366:29: warning: conversion to 'long unsigned int' from 'int' may change the sign of the result [-Wsign-conversion]
  366 |             uint8_t padding[paddingLength];
      |                             ^~~~~~~~~~~~~
In file included from ../src/core/application.hpp:7,
                 from ../src/core/route/handlers/graphql_handler.cpp:6:
../subprojects/fastcgi++/include/fastcgi++/manager.hpp:64:11: warning: 'class Fastcgipp::Manager_base' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
   64 |     class Manager_base

I'd prefer to remedy -Wnon-virtual-dtor, -Wsign-conversio, -Wunused-parameter corresponding code which given these warnings for possible using the library with the -pedantic and -Werror.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant