Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate xxHash and ntHash as optional hashing algorithms #3

Open
edawson opened this issue Oct 26, 2018 · 1 comment
Open

Incorporate xxHash and ntHash as optional hashing algorithms #3

edawson opened this issue Oct 26, 2018 · 1 comment

Comments

@edawson
Copy link
Owner

edawson commented Oct 26, 2018

MurmurHash, while relatively fast / dispersive / backwards compatible with Mash, is slower than some newer algorithms. Moving to xxHash should yield a ~2X speed improvement in the hashing portions of the code, and ntHash should go even faster.

@luizirber
Copy link

Wearing my sourmash hat here:
I think we can bring this up with Mash and support ntHash, there is a field for specifying what hash is being used in the mash JSON schema.

But before going crazy on supporting every hash function under the sun it would be useful to have some agreement to keep everything compatible.

P.S: we also would need to agree on ntHash 1 or 2, see discussion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants