Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tycho 2.7.5 + Domain + Wizard dont work on J17 #2849

Open
cdietrich opened this issue Nov 18, 2023 · 14 comments
Open

Tycho 2.7.5 + Domain + Wizard dont work on J17 #2849

cdietrich opened this issue Nov 18, 2023 · 14 comments
Assignees
Milestone

Comments

@cdietrich
Copy link
Member

Tycho 2.7.5 + Domain + Wizard dont work on J17

Caused by: java.lang.ClassNotFoundException: org.apache.maven.surefire.junit4.JUnit4Provider
at org.eclipse.tycho.surefire.osgibooter.CombinedClassLoader.findClass(CombinedClassLoader.java:39)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
at org.apache.maven.surefire.util.ReflectionUtils.loadClass(ReflectionUtils.java:241)
... 19 more

@cdietrich
Copy link
Member Author

eclipse/mwe#275

@cdietrich cdietrich self-assigned this Nov 18, 2023
@cdietrich cdietrich added this to the Release_2.33 milestone Nov 18, 2023
cdietrich added a commit to xtext/xtext-reference-projects that referenced this issue Nov 18, 2023
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
cdietrich added a commit to xtext/xtext-reference-projects that referenced this issue Nov 18, 2023
@cdietrich
Copy link
Member Author

still does not work in integ test crap :(

@cdietrich cdietrich reopened this Nov 19, 2023
@cdietrich
Copy link
Member Author

might also be a flakyness on github actions

@LorenzoBettini
Copy link
Contributor

What's the problem?

@cdietrich
Copy link
Member Author

2nd attempt worker but log is still full of warnings

@cdietrich
Copy link
Member Author

@szarnekow @LorenzoBettini can someone look into
https://github.com/xtext/xtext-reference-projects/actions/runs/6926300643
is there a way to get screenshots from gh actions?

@LorenzoBettini
Copy link
Contributor

@cdietrich if you mean screenshots generated by SWTBot, this is how I do https://github.com/eclipse-emf-parsley/emf-parsley/blob/master/.github/workflows/maven.yml#L61

@cdietrich
Copy link
Member Author

Yes I mean these

@LorenzoBettini
Copy link
Contributor

concerning the failing test: I'd increase the SWTBot timeout (e.g., -Dorg.eclipse.swtbot.search.timeout=20000), and/or I'd also use flaky test support from Maven/Tycho, how we do in Xtext https://github.com/eclipse/xtext/blob/main/.mvn/maven.config#L3 or how I do in EMF Parsley https://github.com/eclipse-emf-parsley/emf-parsley/blob/master/releng/org.eclipse.emf.parsley.parent/pom.xml#L810C9-L810C9

@cdietrich
Copy link
Member Author

Can you provide pr

@LorenzoBettini
Copy link
Contributor

OK, later today.
Do you have any preference for the solutions?
I don't remember well how those projects were structured, I hope I find my way ;)

@cdietrich
Copy link
Member Author

There is only one swt project bellow integration tests

@cdietrich cdietrich modified the milestones: Release_2.33, Release_2.34 Nov 21, 2023
@cdietrich
Copy link
Member Author

still flaky.

https://github.com/xtext/xtext-reference-projects/compare/cd_refresh?expand=1

maybe you can also find some time to have a look
@LorenzoBettini @szarnekow

@LorenzoBettini
Copy link
Contributor

It says

org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 600000 ms.: Process still not terminated.
	at org.eclipse.xtext.swtbot.tests.XtextNewProjectWizardTest.xtextProject_webIntegration_withGradle_plain(XtextNewProjectWizardTest.java:386)

Can it take so long for the gradle project(s)?

Maybe we can pass a Monitor to waitForBuild that logs what's happening?

I don't think I can work on that today.

@cdietrich cdietrich modified the milestones: Release_2.34, Release_2.35 Feb 27, 2024
@cdietrich cdietrich modified the milestones: Release_2.35, Release_2.36 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants