Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility to configure the encoding in the IResourcesSetupUtil.createTempFile #2844

Open
miklossy opened this issue Nov 16, 2023 · 6 comments
Open

Possibility to configure the encoding in the IResourcesSetupUtil.createTempFile #2844

miklossy opened this issue Nov 16, 2023 · 6 comments
Labels
help_wanted

Comments

@miklossy
Copy link
Contributor

The IResourcesSetupUtil.createTempFile should be overloaded with a signature that accepts not only the fileName, the suffix and the content, but the encoding as well.

This could help to overcome encoding problem within the test cases @hannesN just encountered in a customer project.
@cdietrich
Copy link
Member

What about the other createFile methods

@miklossy
Copy link
Contributor Author

We can also extend the IResourcesSetupUtil.createFile method with an additional encoding parameter.

@cdietrich
Copy link
Member

Change or add additional? The first would break compatibility

@hannesN
Copy link
Contributor

hannesN commented Nov 16, 2023

Add!

@hannesN
Copy link
Contributor

hannesN commented Nov 16, 2023

I can implement this on friday, if you agree.

@miklossy
Copy link
Contributor Author

Thanks you @hannesN !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help_wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdietrich @hannesN @miklossy