Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read from the editor preference store, not the global preference store, to retrieve formatting settings #245

Open
p-bakker opened this issue Sep 15, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@p-bakker
Copy link

See the discussion going on at eclipse-wildwebdeveloper/wildwebdeveloper#474, from eclipse-wildwebdeveloper/wildwebdeveloper#474 (comment) onwards

Currently LSP4E seems to read formatting settings like 'insert tabs for spaces' from the global preference store. Projects like https://github.com/angelozerr/ec4e however allow customizing such settings on a project by project basis and offers more settings, like trim_trailing_whitespace and insert_final_newline.

It would make the dev experience so much better if the settings from .editorconfig, applied to the editor preference store by ec4e, would get picked up by LSP4E for the FormattingOptions for documentFormatting, rangeFormatting and onTypeFormatting commands

angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Oct 28, 2022
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Nov 1, 2022
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Nov 1, 2022
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
@sebthom sebthom added the enhancement New feature or request label Jan 14, 2023
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Apr 3, 2023
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Apr 3, 2023
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Apr 3, 2023
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Apr 3, 2023
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Apr 3, 2023
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Apr 3, 2023
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4e that referenced this issue Apr 3, 2023
Fixes eclipse#245

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants