Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StartUpDelay and ActionStepLength do not work together #14229

Open
Domsall opened this issue Jan 16, 2024 · 0 comments · May be fixed by #14288
Open

StartUpDelay and ActionStepLength do not work together #14229

Domsall opened this issue Jan 16, 2024 · 0 comments · May be fixed by #14288
Labels
a:sumo

Comments

@Domsall
Copy link
Contributor

Domsall commented Jan 16, 2024

Right now:

  • myTimeSinceStartup gets set to 0 when a vehicle is standing and waiting
  • myTimeSinceStartup increases, when the vehicle/driver wants to start up
  • With ActionStepLength, myTimeSinceStartup gets set to 0 inbetween each ActionStep

sumo/src/microsim/MSVehicle.cpp

Lines 4415 to 4428 in 50b4369

if (vNext <= SUMO_const_haltingSpeed && myWaitingTime > MSGlobals::gStartupWaitThreshold && rawAccel <= accelThresholdForWaiting()) {
myTimeSinceStartup = 0;
} else if (isStopped()) {
// do not apply startupDelay for waypoints
if (getCarFollowModel().startupDelayStopped() && getNextStop().pars.speed <= 0) {
myTimeSinceStartup = DELTA_T;
} else {
// do not apply startupDelay but signal that a stop has taken place
myTimeSinceStartup = getCarFollowModel().getStartupDelay() + DELTA_T;
}
} else {
// identify potential startup (before other effects reduce the speed again)
myTimeSinceStartup += DELTA_T;
}

Possible solution:

  • if (vNext <= SUMO_const_haltingSpeed && myWaitingTime > MSGlobals::gStartupWaitThreshold && rawAccel <= accelThresholdForWaiting() && myActionStep)

ToDo (for me as reminder):

  1. Create a test that shows this issue
  2. Change the Code
  3. Update all tests (check for unintended behavior)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:sumo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

StartupDelay with ActionSteps Domsall/sumo
3 participants
@behrisch @m-kro @Domsall