Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build-test pipeline doesn't support custom aqa-test repo #19231

Open
fengxue-IS opened this issue Mar 26, 2024 · 4 comments · Fixed by #19281 · May be fixed by #19318
Open

Build-test pipeline doesn't support custom aqa-test repo #19231

fengxue-IS opened this issue Mar 26, 2024 · 4 comments · Fixed by #19281 · May be fixed by #19318
Labels
comp:build comp:test

Comments

@fengxue-IS
Copy link
Contributor

Launching a build via the jenkins pipeline doesn't allow passing in a custom aqa-test repo/branch. This makes testing against excluded test needing a lot of extra work in order to ensure test coverage without generating regressions.

FYI @llxia
@llxia
Copy link
Contributor

llxia commented Apr 1, 2024

Talked with @gita-omr , we should also support custom EXTRA_OPTIONS

@llxia llxia mentioned this issue Apr 8, 2024
Merged
@llxia
Copy link
Contributor

llxia commented Apr 8, 2024

We will allow users to set ADOPTOPENJDK_REPO, ADOPTOPENJDK_BRANCH, USE_TESTENV_PROPERTIES and EXTRA_OPTIONS in Pipeline-Build-Test-Personal job.

When USE_TESTENV_PROPERTIES is set to true, testenv.properties file in ADOPTOPENJDK_REPO and ADOPTOPENJDK_BRANCH will be used. (i.e., https://github.com/adoptium/aqa-tests/blob/master/testenv/testenv.properties). testenv.properties can be used to set other repos and branches (i.e., for openjdk jdk11 repo, set JDK11_OPENJ9_REPO)

@llxia
Copy link
Contributor

llxia commented Apr 12, 2024

Pipeline-Build-Test-Personal job config is updated to include the above test pipeline parameters.

@keithc-ca
Copy link
Contributor

Re-opening: #19281 was reverted by #19317.

@keithc-ca keithc-ca reopened this Apr 12, 2024
@llxia llxia linked a pull request Apr 12, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:build comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test pipeline parameters llxia/openj9
Add test pipeline parameters llxia/openj9
3 participants
@fengxue-IS @keithc-ca @llxia