Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add nullable = false to relevant fields #749

Open
mtsitrin opened this issue Mar 28, 2024 · 0 comments
Open

refactor: add nullable = false to relevant fields #749

mtsitrin opened this issue Mar 28, 2024 · 0 comments
Labels
t:refactor

Comments

@mtsitrin
Copy link
Contributor

e.g
DymintPubKey in the MsgCreateRollapp should be mandatory.
w/o nullable = false, it can be nil and therefor always checked for in the code.

mandatory complex fields, should be set with nullable = false in the proto files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t:refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtsitrin