Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-loading of more icons fails for tall browser windows #3

Open
jamesscottbrown opened this issue Apr 25, 2021 · 5 comments
Open
Labels

Comments

@jamesscottbrown
Copy link

jamesscottbrown commented Apr 25, 2021

After doing a search, or clicking on the name of a category, 3 rows of icons are displayed.

If I opened bioicons in a full-height browser window on my desktop, there is a gap between the last row of images and the bottom of this page, and this prevents the auto-loading of images from working - there is no way for me to see the remaining images.

However, if I reduce the height of the browser window, this triggers auto-loading, and scrolling then loads more images.

@duerrsimon
Copy link
Owner

Thanks for flagging this. What's your browser and your screen resolution so that I can reproduce?

@jamesscottbrown
Copy link
Author

My outer window size is 1920 x 2160 (one half of a 4K screen); my inner window size is 1920 x 2025.

This happens is both Firefox and Chromium

@duerrsimon
Copy link
Owner

I implemented an easy fix by preloading double the amount of icons at the beginning. Does that work for you?

@jamesscottbrown
Copy link
Author

Yes, this solves the problem for me (though it still occurs under the more unusual circumstance of using a full-screen browser window on a 4K monitor in portrait orientation).

@duerrsimon
Copy link
Owner

great. I'll see if you can make the infinite scrolling function "smarter" to account for this if I have time.
4K in portrait certainly is an edge case haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants