Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(worker) Add support for pre in properties #4988

Merged
merged 7 commits into from
May 16, 2024
Merged

✨(worker) Add support for pre in properties #4988

merged 7 commits into from
May 16, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented May 15, 2024 •
edited

Description

The package @fast-check/worker was not compatible with fc.pre. As such users were unable to rely on one of the core built-in primitives provided by fast-check. This PR adds support for it.

Fixes #4473

Checklist — Don't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✨ Introduce new features
  • Impacts: properties with fc.pre will behave correctly

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 15, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3bae03e:

Sandbox Source
@fast-check/examples Configuration

dubzzz
dubzzz commented May 15, 2024
View reviewed changes
.yarn/versions/7b62c29f.yml Outdated Show resolved Hide resolved
@dubzzz dubzzz enabled auto-merge (squash) May 15, 2024 07:23
@github-actions GitHub Actions
Copy link
Contributor

👋 A preview of the new documentation is available at: http://664464159f02ef69ca801312--dubzzz-fast-check.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

👋 A preview of the new documentation is available at: http://6644685934759e6c1c09df92--dubzzz-fast-check.netlify.app

@dubzzz dubzzz disabled auto-merge May 16, 2024 18:34
@dubzzz dubzzz enabled auto-merge (squash) May 16, 2024 18:34
@github-actions GitHub Actions
Copy link
Contributor

👋 A preview of the new documentation is available at: http://664653fa64a029033d29f973--dubzzz-fast-check.netlify.app

@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (0b5f1ad) to head (3bae03e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4988   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files         213      213           
  Lines       16296    16296           
  Branches     2667     2667           
=======================================
  Hits        15787    15787           
  Misses        509      509
Flag Coverage Δ
unit-tests 96.87% <ø> (ø)
unit-tests-18.x-Linux 96.87% <ø> (ø)
unit-tests-20.x-Linux 96.87% <ø> (ø)
unit-tests-22.x-Linux 96.87% <ø> (ø)
unit-tests-latest-Linux 96.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit c72a33e into main May 16, 2024
60 checks passed
@dubzzz dubzzz deleted the pre-support branch May 16, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not sure worker properly support fc.pre
1 participant
@dubzzz