Replace usage of in_array() in MigrateExecutable::handleMissingSourceRows #5766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urceRows(). Adds a new method getSourceIdKey() to serialize the source ID data into a unique key for retrieval later. Refer to drush-ops#5765
| */ | ||
| protected function getSourceIdKey(array $source_id): string | ||
| { | ||
| return implode('-', $source_id); |
There was a problem hiding this comment.
I wonder how safe is this
There was a problem hiding this comment.
I don't know the full extent of what is possible to appear in the $source_id array values, but from my investigation it is mostly entity IDs, revision IDs, and simple strings. Of which, most cases involve one or two values.
I am open to alternate ways of serializing the array values into a unique key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #5765