Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlyoutPage Shadow works incorrectly on iOS #22169

Closed
Kistarlan opened this issue May 2, 2024 · 2 comments · Fixed by #22351
Closed

FlyoutPage Shadow works incorrectly on iOS #22169

Kistarlan opened this issue May 2, 2024 · 2 comments · Fixed by #22351
Labels
area-controls-flyoutpage FlyoutPage platform/iOS 🍎 t/bug Something isn't working

Comments

@Kistarlan
Copy link

Kistarlan commented May 2, 2024 •
edited

Description

There are 3 examples of Shadow defects with FlyoutPage and PhoneFlyoutPageRenderer:
https://github.com/dotnet/maui/assets/18734152/645edae0-dc59-4a18-b290-c8b880634f0a
https://github.com/dotnet/maui/assets/18734152/c257901b-b0e8-4bb7-a335-736344aa7c82
https://github.com/dotnet/maui/assets/18734152/eef9996e-2887-4c06-ad99-eebf229a793a

You can see next defects:
When we have LeftToRight flow direction:

  1. Shadow appearead only in Max position but should be started when we move FlyoutPage
  2. The shadow should be the same when we release the tapping gesture as when we bring the page to its maximum position

When we have RightToLeft flow direction:

  1. Shadow should start from LightGrey but we see Black screen instead
  2. Shadow blinking when we end Pan gesture

Steps to Reproduce

  1. For the first I set FlyoutLayoutBehavior="Popover" and ios:FlyoutPage.ApplyShadow="true" in FlyoutPage.
  2. To be able see Popover on iPhone I inherited from PhoneFlyoutPageRenderer and set FlyoutOverlapsDetailsInPopoverMode = true in constructor
  3. After this I tried to run project with different FlowDirection RightToLeft and LeftToRight

Expected Result

  1. When I pan gesture Shadow should smoothly from Light Grey to Grey
  2. Behaviour from should be the same when we have RightToLeft and LeftToRight flow direction
  3. The shadow should be the same when we release the tapping gesture as when we bring the page to its maximum position
  4. It would be good if you provide possibility use Popover style for Phones idiom. Even Microsoft Outlook, Teams etc have Popover type with shadow.

Link to public reproduction project repository

No response

Version with bug

8.0.21 SR4.1

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

No response

Did you find any workaround?

Not yet, but earlier on Xamarin I created own PhoneMasterDetailRenderer to fix these defects, because most of methods are hidden for inherit

Relevant log output

No response
@Kistarlan Kistarlan added the t/bug Something isn't working label May 2, 2024
@Eilon Eilon added the area-controls-flyoutpage FlyoutPage label May 2, 2024
@github-actions github-actions bot mentioned this issue May 2, 2024
Closed
@PureWeen
Copy link
Member

PureWeen commented May 2, 2024

/similarissues

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

kubaflo added a commit to kubaflo/maui that referenced this issue May 12, 2024
@kubaflo
Fixed dotnet#22169
7cc03f6
@kubaflo kubaflo mentioned this issue May 12, 2024
Merged
@github-actions github-actions bot mentioned this issue May 13, 2024
Open
PureWeen pushed a commit that referenced this issue May 13, 2024
@kubaflo
[iOS] FlyoutPage Shadow works incorrectly on iOS - fix (#22351)
b2870c7 
* Fixed #22169

* Update PhoneFlyoutPageRenderer.cs

* Code refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-controls-flyoutpage FlyoutPage platform/iOS 🍎 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[iOS] FlyoutPage Shadow works incorrectly on iOS - fix kubaflo/maui
4 participants
@Eilon @PureWeen @samhouts @Kistarlan