FS1118 on inlined function in private module from SDK 8.0.300 #17161 #17168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KevinRansom
added
the
NO_RELEASE_NOTES
KevinRansom
changed the title
KevinRansom
added
NO_RELEASE_NOTES
|
Thanks for the quick fix! Does this also fix the warning for class members? |
abonie
approved these changes
May 17, 2024
|
/backport to release/dev17.10 |
|
Started backporting to release/dev17.10: https://github.com/dotnet/fsharp/actions/runs/9130940180 |
|
@vzarytovskii backporting to release/dev17.10 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: temp
Using index info to reconstruct a base tree...
M src/Compiler/Optimize/Optimizer.fs
M tests/AheadOfTime/Trimming/check.ps1
Falling back to patching base and 3-way merge...
Auto-merging tests/AheadOfTime/Trimming/check.ps1
CONFLICT (content): Merge conflict in tests/AheadOfTime/Trimming/check.ps1
Auto-merging src/Compiler/Optimize/Optimizer.fs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 temp
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@loop-evgeny, Sorry not to get back to you, it was 1:00 am last night when I propped this PR. I believe this will take care of the class issues too, I will add test cases for it and also verify #17161. |
vzarytovskii
approved these changes
May 20, 2024
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17161
This is a regression it should go into 8.0.300
/cc @vzarytovskii , @baronfel