Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryLoadNativeLibraryFromFile shouldn't just swallow all exceptions #1310

Closed
glopesdev opened this issue May 18, 2024 · 0 comments · Fixed by #1312
Closed

TryLoadNativeLibraryFromFile shouldn't just swallow all exceptions #1310

glopesdev opened this issue May 18, 2024 · 0 comments · Fixed by #1312

Comments

@glopesdev
Copy link
Contributor

This is happening here:

TorchSharp/src/TorchSharp/Torch.cs

Line 63 in 3d01e74

} catch {

Instead, it should follow the pattern from TryLoadNativeLibraryByName just below:

TorchSharp/src/TorchSharp/Torch.cs

Line 78 in 3d01e74

trace.AppendLine($" Failed to load native component {name} relative to {assembly.Location}: {exn.Message}");

The current implementation makes it really hard to debug what is happening when undocumented OS-specific exceptions thrown by the TryLoad method bubble up to surface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Append unhandled exception message to trace glopesdev/TorchSharp
1 participant
@glopesdev