Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1006: flag more functions #1528

Open
dominikh opened this issue Apr 24, 2024 · 0 comments · May be fixed by #1542
Open

SA1006: flag more functions #1528

dominikh opened this issue Apr 24, 2024 · 0 comments · May be fixed by #1542
Labels
enhancement false-negative

Comments

@dominikh
Copy link
Owner

We're at least missing fmt.Errorf, log.Fatalf, and several methods on log.Logger and methods from testing.
arp242 added a commit to arp242/go-tools that referenced this issue May 25, 2024
@arp242
SA1006: flag more functions
b36eef3 
Flag all stdlib functions that have both a Printf() and Print() variant.

Found with:

        % rg -g '!internal/' -g '!cmd/' '^func ([()*a-zA-Z0-9_ ]+)?[A-Z]\w+\(\w+ string, \w+ \.\.\.any\)'

(will need to filter out some false positives)

Fixes dominikh#1528
@arp242 arp242 linked a pull request May 25, 2024 that will close this issue
Open
@Jacalz Jacalz mentioned this issue May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement false-negative
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SA1006: flag more functions arp242/go-tools
1 participant
@dominikh