Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please respect BUILD_SHARED_LIBS variable, and make both shared ans static library names the same #104

Open
yurivict opened this issue Nov 15, 2018 · 2 comments · May be fixed by #134
Open

Please respect BUILD_SHARED_LIBS variable, and make both shared ans static library names the same #104

yurivict opened this issue Nov 15, 2018 · 2 comments · May be fixed by #134
Labels
needs-patch simple-fix

Comments

@yurivict
Copy link

BUILD_SHARED_LIBS is defined in cmake docs (https://cmake.org/cmake/help/v3.0/variable/BUILD_SHARED_LIBS.html) to control this. The reason this is useful is, for example, when FreeBSD (or any other system) has a policy against installing static libs this should be supported by the project itself.

Additionally, there is a confusion resulting in failures like this:
/usr/local/bin/ld: cannot find -ldocopt_s

To avoid such confusion please name both libraries the same way.
@jaredgrubb
Copy link
Member

Can someone provide a patch for this?

@chfast
Copy link

chfast commented Jun 20, 2020

Yes, I will be able to handle this.

@chfast chfast linked a pull request Jun 21, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-patch simple-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declare single library in CMake chfast/docopt.cpp
3 participants
@yurivict @chfast @jaredgrubb