You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With Linux, if DOCKSAL_DNS_DISABLED=1 (This automatically sets DOCKSAL_DNS_DOMAIN=docksal.site and DOCKSAL_NO_DNS_RESOLVER=1.) fin function check_docksal_environment() will append nameserver ${DOCKSAL_IP} into /etc/resolv.conf.
Steps to reproduce the issue:
Set DOCKSAL_DNS_DISABLED=1 into docksal.env
Reset docksal: fin system reset
check that the dns container is no longer running: docker ps | grep docksal-dns
Restart a projet (to trigger check_docksal_environment): fin p restart
Describe the results you received:
nameserver ${DOCKSAL_IP} has been append to the first line of /etc/resolv.conf.
Describe the results you expected:
No /etc/resolv.conf modification
Proposed solution:
I propose to add a condition into fincheck_docksal_environment ():
Thanks for reporting this. I incorporated your proposed fix and also set DOCKSAL_DNS_DISABLED=1 by default in preparation for a complete removal of this deprecated functionality.
Description
With Linux, if
DOCKSAL_DNS_DISABLED=1
(This automatically setsDOCKSAL_DNS_DOMAIN=docksal.site
andDOCKSAL_NO_DNS_RESOLVER=1
.)fin
functioncheck_docksal_environment()
will appendnameserver ${DOCKSAL_IP}
into/etc/resolv.conf
.Steps to reproduce the issue:
DOCKSAL_DNS_DISABLED=1
intodocksal.env
fin system reset
docker ps | grep docksal-dns
check_docksal_environment
):fin p restart
Describe the results you received:
nameserver ${DOCKSAL_IP}
has been append to the first line of/etc/resolv.conf
.Describe the results you expected:
No
/etc/resolv.conf
modificationProposed solution:
I propose to add a condition into
fin
check_docksal_environment ()
:The text was updated successfully, but these errors were encountered: