Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortpom should fail instead of silently sort on spotless:check #2068

Open
tisonkun opened this issue Mar 19, 2024 · 2 comments
Open

Sortpom should fail instead of silently sort on spotless:check #2068

tisonkun opened this issue Mar 19, 2024 · 2 comments

Comments

@tisonkun
Copy link
Contributor

@Ekryd I'm trying to merge my sortpom config into spotless config build find that it doesn't failed on spotless:check but actually verifyFail == Sort.

I suppose we should use verifyFail == Stop so that it's the same manner as spotless.

Originally posted by @tisonkun in #2049 (comment)

@tisonkun
Copy link
Contributor Author

@nedtwigg I'm not quite sure how check and format works (significant codepath).

I try to read the code but it's too dynamic to figure out. If you can describe the workflow perhaps I can try to work on a fix.

@Ekryd
Copy link

Ekryd commented Mar 20, 2024

My experience with Spotless is very limited, so I will hand this over to the kind folks that maintain spotless. 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants