Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fread return value ignored #57

Open
mathstuf opened this issue Feb 1, 2018 · 1 comment
Open

fread return value ignored #57

mathstuf opened this issue Feb 1, 2018 · 1 comment

Comments

@mathstuf
Copy link
Contributor

mathstuf commented Feb 1, 2018

In include/diy/storage.hpp, fread is used, but its return value is ignored.

virtual inline void load_binary(char* x, size_t count)          { fread(x, 1, count, file); }

fread returns the number of items read, so when requesting 1000 bytes, a read may read just 10 and further calls are necessary.

@mrzv
Copy link
Member

mrzv commented Feb 1, 2018

That's a good point. A pull request correcting this would be welcome. (I won't get to fixing this myself until next week.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants