-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deno has panicked when defineProperty
used on Deno "Object"
#743
Comments
Accidental duplicate of #742 I think |
Hi @dsherret, |
Sorry, I didn't read it closely enough. |
Thanks, @dsherret! |
devsnek
added a commit
that referenced
this issue
May 21, 2024
Fixes: #742 Fixes: #743 `pending_mod_evaluation` is set before calling Module::Evaluate, and unset in the promise handlers for the promise returned by evaluate. If setting up those promise handlers fails for some reason, we can end up in a case where evaluation has finished but we haven't unset `pending_mod_evaluation`, which makes the core event loop assume that there is a pending stalled tla message, and it ends up panicking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I want to report the following bug found while using
defineProperty
on Deno's built-in "Object":Details:
Platform: macos x86_64
Version: Deno 1.43.3
How To Reproduce:
Run the following script to trigger Deno's panic:
The text was updated successfully, but these errors were encountered: