Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Better GitHub markdown reporting with emojis for checkmark ✅ and cross ❌ #2729

Open
bgalvao opened this issue Jan 24, 2024 · 1 comment
Labels

Comments

@bgalvao
Copy link
Contributor

bgalvao commented Jan 24, 2024

Is your feature request related to a problem? Please describe.

When I get a markdown report for GitHub, I get some native characters that don't stand out in the summary deepchecks report (cml markdown feature).

Describe the solution you'd like

For the emojis to show in the markdown in GitHub. Example screenshot 👇🏼

image

Solution is to find and replace the characters with their counterparts in GitHub markdown:

  • ❌ (:x:)
  • ✅ (:white_check_mark)

Additional context

I implemented this CML markdown feature last year. Guess I can improve it a bit.

@github-actions github-actions bot added needs triage Issue needs to be labeled and prioritized linear labels Jan 24, 2024
@bgalvao bgalvao changed the title [FEAT] [FEAT] Better GitHub markdown reporting with emojis for checkmark ✅ and cross ❌ Jan 24, 2024
@noamzbr
Copy link
Collaborator

noamzbr commented Jan 28, 2024

Thanks for opening this @bgalvao! So essentially you're suggesting replacing what emojies are used in SuiteResultsave_as_cml_markdown? Can I assign this issue you you?

@noamzbr noamzbr removed the needs triage Issue needs to be labeled and prioritized label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants