Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add airspeed velocity benchmarks #231

Open
Illviljan opened this issue Jan 24, 2022 · 1 comment · May be fixed by #234
Open

Add airspeed velocity benchmarks #231

Illviljan opened this issue Jan 24, 2022 · 1 comment · May be fixed by #234

Comments

@Illviljan
Copy link

Illviljan commented Jan 24, 2022

When I've been reading articles about change points there's a lot of discussions about performance. But I don't see a lot of benchmarks here in ruptures.

I suggest to use airspeed velocity (used by numpy/pandas/xarray etc) and make some simple tests that loops through each of the algorithms.

asv can be difficult to setup locally (at least for me) so I suggest to add it to the CI as well to avoid complexity for new (and old) contributors:
xarray has a nice workflow that you can use (PR: pydata/xarray#5796) and I suggest to try to follow the same folder structure as xarray does.

Interesting reading:
https://labs.quansight.org/blog/2021/08/github-actions-benchmarks/

@Illviljan Illviljan linked a pull request Jan 25, 2022 that will close this issue
1 task
@deepcharles
Copy link
Owner

Great suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants