Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit bug report to skimage for offset case #146

Closed
2 tasks done
dchaley opened this issue Feb 8, 2024 · 3 comments
Closed
2 tasks done

Submit bug report to skimage for offset case #146

dchaley opened this issue Feb 8, 2024 · 3 comments

Comments

@dchaley
Copy link
Owner

dchaley commented Feb 8, 2024

While working on #128 I found some discrepancies between my implementation and scikit's that I couldn't explain, when using a non-null offset. (aka recentering the footprint)

After a lot of head-banging, I actually think I found a bug in the scikit implementation.

Work:

@dchaley
Copy link
Owner Author

dchaley commented Feb 8, 2024

The bug report is complete. cc @lynnlangit

I'll take another look, it's probably good enough, then I'll submit an issue.

Ideally, I'd have an understanding how to fix the issue.
Then, I can compare my impl vs the fixed scikit impl.
But I'm not 100% sure how to fix it yet.

Not sure the logistics of merging an algorithm replacement that doesn't match??
Maybe I should be testing vs the opencv implementation, which seems to work. (It's also more obviously correct in principle, it's a much simpler algorithm.)

@lynnlangit
Copy link
Collaborator

nicely documented

use the simplest thing that works

@dchaley
Copy link
Owner Author

dchaley commented Feb 8, 2024

Bug report submitted: scikit-image/scikit-image#7315

@dchaley dchaley closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants