Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for Enabling Lint On Change Are Not Clear #359

Open
dprothero opened this issue Oct 14, 2021 · 4 comments
Open

Instructions for Enabling Lint On Change Are Not Clear #359

dprothero opened this issue Oct 14, 2021 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@dprothero
Copy link

Describe the bug
Linting isn't running automatically while I type in a Markdown file, even though I have "Editor: Format On Type" turned on.

I am also running the markdownlint extension, and it is linting in real time as I type.

To Reproduce
Steps to reproduce the behavior:

  1. Open any Markdown file
  2. Type a sentence with a grammar issue (e.g. this sentence doesn't start with a capital letter.)
  3. Linting is NOT run
  4. Save the Markdown file
  5. Now, linting runs.

Expected behavior
I would expect the linting to run as I'm typing, similar to how markdownlint does.

Screenshots
The appropriate setting IS enabled:
image

Demonstration of the issue:
langtool

Environment & Configuration (please complete the following information):

  • OS + Version: Mac 11.6
  • VS Code Version: 1.61.0
  • LanguageTool Linter Version: 0.18.0
  • LanguageTool Version: unsure, just ran docker command, so using "latest" image
  • Service Configuration: local docker instance
  • Service Classpath (if 'managed'): N/A

Additional context
N/A

@dprothero dprothero added the bug Something isn't working label Oct 14, 2021
@davidlday
Copy link
Owner

Thanks for opening this issue! I looked at the README again, and I think I left out some instructions. There are 2 other toggles that you can check to enable linting on-demand and linting on open, but they're under the "LanguageTool Linter" settings specifically. Can you check to see if one or both of these are enabled, and if not, if enabling the "Lint On Change" fixes the issue? They are off by default.

Screen Shot 2021-10-14 at 4 11 02 PM

@dprothero
Copy link
Author

YES. That did the trick! Thanks for the quick reply.

@davidlday
Copy link
Owner

You bet! I'm going to leave this open and change to title to fix the documentation. Thanks for bringing this to my attention.

@davidlday davidlday changed the title Linting not running on a Markdown file until I save. Instructions for Enabling Lint On Change Are Not Clear Oct 14, 2021
@davidlday davidlday added documentation Improvements or additions to documentation and removed bug Something isn't working labels Oct 14, 2021
@davidlday davidlday added this to the Version 1.0 milestone Oct 14, 2021
@davidlday
Copy link
Owner

@dprothero - thanks for the kind words and review on the extension marketplace!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants