Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: deprecation of slash character as division #191

Open
DonVito1982 opened this issue Nov 15, 2023 · 0 comments · May be fixed by #197
Open

[Bug]: deprecation of slash character as division #191

DonVito1982 opened this issue Nov 15, 2023 · 0 comments · May be fixed by #197
Labels

Comments

@DonVito1982
Copy link

Summary

Sass deprecated the use of the slash character / as division sign in 1.3.3 and such use of the character will be removed in Sass 2.0.0. See Breaking changes announcement. Therefore *.scss files should be updated accordingly

To Reproduce

Steps to reproduce the behaviour:

  1. Serve a jekyll blog that uses alembic as remote theme
  2. Confirm that deprecation warnings appear while building the site

Expected behaviour

The site should be built without warnings.

Sample warning

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($get-size, nth($sizes, 1)) or calc($get-size / nth($sizes, 1))

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
197 │       font-size: #{$get-size / nth($sizes, 1)}rem;
    │                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    /tmp/jekyll-remote-theme-20231114-921773-fxtmqz/_sass/sassline-base/_mixins.scss 197:20       fontsize()
    /tmp/jekyll-remote-theme-20231114-921773-fxtmqz/_sass/sassline-base/_typography.scss 14:3     @import
    /tmp/jekyll-remote-theme-20231114-921773-fxtmqz/_sass/_sassline-base.scss 6:9                 @import
    alembic.scss 7:3                                                                              @import

Environment

  • Ruby version: [e.g. 3.1.2]
  • Jekyll version: [e.g. 4.1.0]
  • Theme version: [e.g. 4.1.0]
@DonVito1982 DonVito1982 changed the title [Bug]: deprecation of slah character as division [Bug]: deprecation of slash character as division Nov 15, 2023
@daviddarnes daviddarnes linked a pull request Dec 31, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant