Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post install script fails when behind proxy because node-fetch does not support standard proxy environment variables (like HTTP_PROXY) #349

Open
itai-huawei opened this issue Oct 8, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@itai-huawei
Copy link

in case of running against an organizational proxy, it is not possible to install the project due to the use of node-fetch that does not support this.

import fetch from "node-fetch";

@daveshanley
Copy link
Owner

Don't give up so easily :)

There are other, simpler ways to install vacuum if you can't use node.

https://quobix.com/vacuum/installing/

@daveshanley
Copy link
Owner

We can't fix the node-fetch issue, so please, try another way to install vacuum, the easiest.. is via CURL.

curl -fsSL https://quobix.com/scripts/install_vacuum.sh | sh

@itai-huawei
Copy link
Author

but i want to install it as part of my node.js project. what is your suggestion?

@itai-huawei
Copy link
Author

would you mind if i contribute a change to the code to use some other library instead of node-fetch? so that this can be native to javascript?

@daveshanley daveshanley reopened this Oct 9, 2023
@daveshanley
Copy link
Owner

Of course! What library do you intend to swap it out for?

This is why vacuum is opensource! So we can all make it better together.

@itai-gendler
Copy link

i think that most simple way will be to use axios for this. it is well adopted and works well with such configuration.
if you are ok with this, i can create a pull request for this

@itai-gendler
Copy link

FYI your work is nothing less than amazing :)

@daveshanley
Copy link
Owner

FYI your work is nothing less than amazing :)

Thank you, so very much! I really appreciate that.

@daveshanley daveshanley added the enhancement New feature or request label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants