Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsidian Wiki remark plugin should export node type #975

Open
ShravanSunder opened this issue Jul 12, 2023 · 3 comments
Open

Obsidian Wiki remark plugin should export node type #975

ShravanSunder opened this issue Jul 12, 2023 · 3 comments

Comments

@ShravanSunder
Copy link

ShravanSunder commented Jul 12, 2023

This would make it easier to use the library with unist

@rufuspollock
Copy link
Member

@ShravanSunder thanks for the feedback. Could you tell us a bit more about how we should do that ...

@ShravanSunder
Copy link
Author

This is the line right here, where its created and defined as an object. There should be a typescript type for this that's exported. It would make it much easier to use this for parsing with uinst and mdast. 🙇🏾

https://github.com/datopian/portaljs/blob/b940c82d93e6537b237f4f9500ba47c1367a7bcb/packages/remark-wiki-link/src/lib/fromMarkdown.ts#L46-L59

@rufuspollock
Copy link
Member

@ShravanSunder thanks - would you be up for doing a pull request? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💬 Discussion
Development

No branches or pull requests

2 participants