Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dm.scaffold.fuzzy_scaffolding #114

Open
hadim opened this issue Jun 27, 2022 · 2 comments
Open

Refactor dm.scaffold.fuzzy_scaffolding #114

hadim opened this issue Jun 27, 2022 · 2 comments
Labels
enhancement New feature or request low-priority

Comments

@hadim
Copy link
Contributor

hadim commented Jun 27, 2022

dm.scaffold.fuzzy_scaffolding is quite a powerful function but its output is often hard to understand and also process for downstream task.

We could keep backward compat by keeping dm.scaffold.fuzzy_scaffolding and propose an alternative function that will do the same kind of processing under the hood but return a data structure that is more intuitive and easier to use (a dataframe or a list of dataframe?).

@Pakman450
Copy link
Contributor

Pakman450 commented May 3, 2023

@hadim Ill try to take a jab at this. Let you know what happens. Question: Does the output results have multi valued attributes? I don't know much about the output as of yet, but this dataframe route could make it difficult to implement if there are multiple and/or range of data points for a single resulting input. Thanks.

@maclandrol
Copy link
Member

Thanks @Pakman450

Question: Does the output results have multi valued attributes?

Currently the output is a tuple of list and dicts. I would say for the refactoring, it's perfectly ok to completely rethink the output. Whether a dataframe would be a good fit would need to be assessed, but it's probably fine to have some new structure (a dataclass or something similar) to hold the results. It's likely that the code and output can be simplified too.

Happy to help around that if you are taking a jab at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority
Projects
None yet
Development

No branches or pull requests

3 participants