Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiblingAssociationHook creates incorrect siblings for dbt entities #10406

Open
maiarareinaldo opened this issue May 1, 2024 · 0 comments
Open
Labels
bug Bug report

Comments

@maiarareinaldo
Copy link

Describe the bug
dbt ingestion creates wrong siblings for dbt models that are also defined as sources in the dbt project. Like in the picture, there were suppose to be only l4b_flags Athena and dbt entities in the Composed Of section, instead there are 2 extra dbt models that shouldn't be there. (Note: the 2 extra models are downstream to the l4b_flags one.)

Screenshot 2024-05-01 at 10 47 36

To Reproduce
Steps to reproduce the behavior (a prerequisite is to have a dbt model that is also defined as a source in the dbt project):

  1. Have separate recipes: one to ingest dbt sources only and the other to ingest models only (instead of having a single recipe to ingest the both, this is needed to ensure the models keep their upstream lineage).
  2. Run the sources recipe ingestion
  3. Run the models recipe ingestion
  4. Run the sources recipe ingestion a second time (this is when the bug is introduced).

Expected behavior
The dbt siblings are created correctly.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: iOS
  • Browser: chrome
@maiarareinaldo maiarareinaldo added the bug Bug report label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

1 participant