Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs missing for read_csv, read_fwf and read_table #11122

Open
fjetter opened this issue May 15, 2024 · 3 comments
Open

API docs missing for read_csv, read_fwf and read_table #11122

fjetter opened this issue May 15, 2024 · 3 comments
Labels
documentation Improve or add to documentation good first issue Clearly described and easy to accomplish. Good for beginners to the project.

Comments

@fjetter
Copy link
Member

fjetter commented May 15, 2024

I believe there are still plenty of doc strings missing since the dask-expr migration

For example https://docs.dask.org/en/latest/generated/dask_expr.read_csv.html

image

@fjetter fjetter added good first issue Clearly described and easy to accomplish. Good for beginners to the project. documentation Improve or add to documentation labels May 15, 2024
@joehiggi1758
Copy link

joehiggi1758 commented May 19, 2024

Hello @fjetter - hope you're having a wonderful day!

I'd love to assist here - this would be my first ever PR, how should I help update these doc strings (aka is there a template I can follow)?

Would love to help!

@fjetter fjetter changed the title API docs missing for read_csv API docs missing for read_csv, read_fwf and read_table May 21, 2024
@fjetter
Copy link
Member Author

fjetter commented May 21, 2024

A couple of things here.

First of all, this issue is actually a bit more work than I initially anticipated. A while ago we migrated to a new dataframe backend using https://github.com/dask/dask-expr
We had to move over a couple of different doc strings, see for example dask/dask-expr#1051. These doc strings should also has to be added in that repo.

The original docs for read_csv, read_fwf and read_table where actually auto generated using a template, see
READ_DOC_TEMPLATE

I suspect we can use the same template but will require a slightly different mechanism. I suspect adding

read_csv.__doc__ = READ_DOC_TEMPLATE.format(reader="read_csv", file_type="CSV")

and similar for FWF and table should do the trick. (See here where the legacy readers are defined)

@joehiggi1758
Copy link

@fjetter sounds great I'll take a crack at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve or add to documentation good first issue Clearly described and easy to accomplish. Good for beginners to the project.
Projects
None yet
Development

No branches or pull requests

2 participants