Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Jekyll include to liquidjs render where possible #5768

Open
parlough opened this issue May 4, 2024 · 0 comments
Open

Migrate Jekyll include to liquidjs render where possible #5768

parlough opened this issue May 4, 2024 · 0 comments
Assignees
@parlough
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@parlough
Copy link
Member

parlough commented May 4, 2024 •
edited

The include syntax we're using is supported as a fallback for migration, and render is the appropriate replacement tag. Its included content doesn't inherit its parents scope, reducing the chance of mistakes.
@parlough parlough added infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible. e2-days Can complete in < 5 days of normal, not dedicated, work labels May 4, 2024
@parlough parlough mentioned this issue May 4, 2024
Merged
parlough added a commit that referenced this issue May 6, 2024
@parlough
Migrate from include to render where possible (#5770)
c5ca81e 
Contributes to #5768

Some includes rely on inheriting the parent still, which `render`
purposefully doesn't support. They will need further updates before
being able to migrate. Some rely on global data (such as `site.`
variables), which 11ty doesn't yet expose to `render`, but likely will
in the future. For now, those can keep using `include`.
@parlough parlough self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e2-days Can complete in < 5 days of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parlough