Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'Dart's core libraries' page #5716

Open
1 task
jarrodcolburn opened this issue Apr 12, 2024 · 5 comments
Open
1 task

Update 'Dart's core libraries' page #5716

jarrodcolburn opened this issue Apr 12, 2024 · 5 comments
Assignees
Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.quality Needs improvement in copy quality from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged target.web Target apps on the web platform

Comments

@jarrodcolburn
Copy link
Contributor

Page URL

https://dart.dev/libraries#web-platform-libraries

Page source

https://github.com/dart-lang/site-www/tree/main/src/content/libraries/index.md

Describe the problem

Chart at bottom https://dart.dev/libraries#web-platform-libraries may need updating
image

Expected fix

Should either be revised or note the Note the next generation Js Interop in line with the table at https://dart.dev/interop/js-interop#next-generation-js-interop

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on dart.dev.
@jarrodcolburn jarrodcolburn added the from.page-issue Reported in a reader-filed concern label Apr 12, 2024
@atsansone atsansone added p2-medium Necessary but not urgent concern. Resolve when possible. e0-minutes Can complete in < 60 minutes of normal, not dedicated, work target.web Target apps on the web platform fix.quality Needs improvement in copy quality labels Apr 18, 2024
@atsansone
Copy link
Contributor

@kevmoo : Are you okay with updating this page as the contributor outlines?

@kevmoo
Copy link
Member

kevmoo commented Apr 18, 2024

Yep! CC @srujzs who drove the work on our side

@srujzs
Copy link
Contributor

srujzs commented Apr 18, 2024

I agree with this change. Just two comments though:

  • We should probably still list dart:html (and other Web SDK libraries) and previous JS interop libraries, but mark them as legacy somehow. They still work and we haven't deprecated them, but we should let users know they are legacy. Maybe by adding (legacy) after them and moving them down the list?
  • package:web may or may not make sense to include here as it's not part of the SDK and is built on a web-specific library.

@jarrodcolburn
Copy link
Contributor Author

  • package:web may or may not make sense to include here as it's not part of the SDK and is built on a web-specific library.

I agree it's maybe not ideal to add package:web, but maybe even less ideal to exclude. Speaking from dev experience and given the context of the doc. For precedence, package:js is already listed, so they maybe have already run into same dilemma with js previously.

@srujzs
Copy link
Contributor

srujzs commented Apr 18, 2024

For precedence, package:js is already listed, so they maybe have already run into same dilemma with js previously.

Good point - I'm okay including package:web based on this then. It's also consistent with some of the other areas we mention these libraries.

@atsansone atsansone changed the title [PAGE ISSUE]: 'Dart's core libraries' Update 'Dart's core libraries' page May 15, 2024
@atsansone atsansone self-assigned this May 15, 2024
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.quality Needs improvement in copy quality from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged target.web Target apps on the web platform
Projects
None yet
Development

No branches or pull requests

4 participants