Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_fileSystem_deleteFile_packageConfigJsonFile fails #55580

Closed
Tracked by #53876
scheglov opened this issue Apr 26, 2024 · 0 comments
Closed
Tracked by #53876

test_fileSystem_deleteFile_packageConfigJsonFile fails #55580

scheglov opened this issue Apr 26, 2024 · 0 comments
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@scheglov
Copy link
Contributor

This started to fail at 22da6ed, probably because together this change, and changes to workspace / packages make it that we stop looking at pubspec.yaml inside /home/test, because the only analysis context is /home after removing /home/test/.dart_tool/package_config.json.

It seems to me that we need a way to iterate over all packages, or at least pubspec.yaml files; when we are inside ContextManager and invoke _analyzePubspecYaml.

@pq @keertip
@scheglov scheglov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-server P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Apr 26, 2024
copybara-service bot pushed a commit that referenced this issue May 1, 2024
@pq
mark skipped test as failing
cd6ad63 
See: #55580

Change-Id: Ia3dc798e0a56f7d6e2f5b159cb391e687efa2963
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365182
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
@pq pq mentioned this issue May 6, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scheglov