Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analyzer] No error if augmenting function specifies default values #55569

Open
sgrekhov opened this issue Apr 26, 2024 · 1 comment
Open

[analyzer] No error if augmenting function specifies default values #55569

sgrekhov opened this issue Apr 26, 2024 · 1 comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-macros Implementation of the macros feature P2 A bug or feature request we're likely to work on

Comments

@sgrekhov
Copy link
Contributor

According to the Augmentations specification

It is a compile-time error if:
...

  • The function augmentation specifies any default values.

In fact no such error is reported. See
https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Augmentation-libraries/augmenting_functions_A05_t01.dart
https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Augmentation-libraries/augmenting_functions_A05_t02.dart
These co19 tests fail in the analyzer bacause of this issue
@sgrekhov sgrekhov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-macros Implementation of the macros feature labels Apr 26, 2024
@bwilkerson
Copy link
Member

@scheglov

@bwilkerson bwilkerson added the P2 A bug or feature request we're likely to work on label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-macros Implementation of the macros feature P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @bwilkerson