Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ddc] Make it possible to move all dart.applyMixin() calls to a library link method #55545

Open
nshahan opened this issue Apr 22, 2024 · 0 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler

Comments

@nshahan
Copy link
Contributor

nshahan commented Apr 22, 2024

There is a need to move all class hierarchy connections into a single method in each library so they can be linked after all class definitions have been evaluated. Initially, this meant removing the use of the extends keyword in compiled output and start stitching together prototype chains manually later in the evaluation of a library.

All calls of dart.applyMixin() need to be moved as well so that when new classes are created (this happens in the body of the method) at the time of a mixin application they have the correct superclass set before copying members from one class to another.

The representation of generic type parameters is also intertwined with mixins in some class hierarchies. This is preventing simply moving all calls of dart.applyMixin() to the link method. It might be easier to change the generic class representation first. #31003

@nshahan nshahan added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler
Projects
None yet
Development

No branches or pull requests

1 participant