{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":35726310,"defaultBranch":"main","name":"sdk","ownerLogin":"dart-lang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-05-16T14:14:58.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1609975?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714248241.0","currentOid":""},"activityList":{"items":[{"before":"40ddded2b47d1a401fefe1a33c3e21f8f48ba8e0","after":"9eb838fa00afe8c09034ef99c672e334ff11bc4d","ref":"refs/heads/dev","pushedAt":"2024-04-27T20:04:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Version 3.5.0-109.0.dev\n\nMerge 5b2ea0c7a227d91c691d2ff8cbbeb5f7f86afdb9 into dev","shortMessageHtmlLink":"Version 3.5.0-109.0.dev"}},{"before":"1ff4f72ebcd9a3a48ef93a2b1f57031d36c8fbb2","after":"5b2ea0c7a227d91c691d2ff8cbbeb5f7f86afdb9","ref":"refs/heads/master","pushedAt":"2024-04-27T18:10:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Test. Check path in StaticError.matchLocation()\n\nThis was causing issues with tests when there are two expected\nerrors at the same lines, in different files. The first expected\nerror would (and consume) both actual errors. So, the second expected\nerror would say that is unsatisfied.\n\nChange-Id: I0bd7b56d070732c83d1d87f3dcf8ba20a693028c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364604\nReviewed-by: Bob Nystrom \nCommit-Queue: Konstantin Shcheglov ","shortMessageHtmlLink":"Test. Check path in StaticError.matchLocation()"}},{"before":"1ff4f72ebcd9a3a48ef93a2b1f57031d36c8fbb2","after":"5b2ea0c7a227d91c691d2ff8cbbeb5f7f86afdb9","ref":"refs/heads/main","pushedAt":"2024-04-27T18:10:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Test. Check path in StaticError.matchLocation()\n\nThis was causing issues with tests when there are two expected\nerrors at the same lines, in different files. The first expected\nerror would (and consume) both actual errors. So, the second expected\nerror would say that is unsatisfied.\n\nChange-Id: I0bd7b56d070732c83d1d87f3dcf8ba20a693028c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364604\nReviewed-by: Bob Nystrom \nCommit-Queue: Konstantin Shcheglov ","shortMessageHtmlLink":"Test. Check path in StaticError.matchLocation()"}},{"before":"f5a0dc31f6385bd909a178c0d5bf0ba7e8676fcb","after":"40ddded2b47d1a401fefe1a33c3e21f8f48ba8e0","ref":"refs/heads/dev","pushedAt":"2024-04-27T04:03:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Version 3.5.0-108.0.dev\n\nMerge 1ff4f72ebcd9a3a48ef93a2b1f57031d36c8fbb2 into dev","shortMessageHtmlLink":"Version 3.5.0-108.0.dev"}},{"before":"7173b4dd01632e85d8119e418b82acf35c411d90","after":"f5a0dc31f6385bd909a178c0d5bf0ba7e8676fcb","ref":"refs/heads/dev","pushedAt":"2024-04-27T00:04:12.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Version 3.5.0-107.0.dev\n\nMerge 6357371c0aaf16fef8c3056150959e3d222ad66c into dev","shortMessageHtmlLink":"Version 3.5.0-107.0.dev"}},{"before":"6357371c0aaf16fef8c3056150959e3d222ad66c","after":"1ff4f72ebcd9a3a48ef93a2b1f57031d36c8fbb2","ref":"refs/heads/master","pushedAt":"2024-04-26T23:47:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Mark file system event tests as slow.\n\nRestore timeout for windows-arm64, which did not get faster.\n\nChange-Id: I9f032c25fc69454929348f0589d35200a4728142\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364625\nCommit-Queue: Ryan Macnak \nReviewed-by: Siva Annamalai ","shortMessageHtmlLink":"Mark file system event tests as slow."}},{"before":"6357371c0aaf16fef8c3056150959e3d222ad66c","after":"1ff4f72ebcd9a3a48ef93a2b1f57031d36c8fbb2","ref":"refs/heads/main","pushedAt":"2024-04-26T23:47:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Mark file system event tests as slow.\n\nRestore timeout for windows-arm64, which did not get faster.\n\nChange-Id: I9f032c25fc69454929348f0589d35200a4728142\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364625\nCommit-Queue: Ryan Macnak \nReviewed-by: Siva Annamalai ","shortMessageHtmlLink":"Mark file system event tests as slow."}},{"before":"f02007839d2268da89e83891b377c48f3ee8fcac","after":"6357371c0aaf16fef8c3056150959e3d222ad66c","ref":"refs/heads/master","pushedAt":"2024-04-26T23:06:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[reload_test] Adding diffs to existing tests.\n\nChange-Id: Icf7135ae46159ca834a54849c72405eec83f9b4f\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364384\nReviewed-by: Nicholas Shahan \nCommit-Queue: Mark Zhou ","shortMessageHtmlLink":"[reload_test] Adding diffs to existing tests."}},{"before":"f02007839d2268da89e83891b377c48f3ee8fcac","after":"6357371c0aaf16fef8c3056150959e3d222ad66c","ref":"refs/heads/main","pushedAt":"2024-04-26T23:06:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[reload_test] Adding diffs to existing tests.\n\nChange-Id: Icf7135ae46159ca834a54849c72405eec83f9b4f\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364384\nReviewed-by: Nicholas Shahan \nCommit-Queue: Mark Zhou ","shortMessageHtmlLink":"[reload_test] Adding diffs to existing tests."}},{"before":"adfbcc7657248be8a64ad1313c15f7a58cf15e23","after":"f02007839d2268da89e83891b377c48f3ee8fcac","ref":"refs/heads/master","pushedAt":"2024-04-26T21:40:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[test_runner] Reduce timeouts.\n\nWe've roughly doubled bot speeds; half timeouts to provide pressure against this simply getting filled with slower tests.\n\nChange-Id: I812da7adc6c08e6d484732c2558e0d3f63b2694a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364385\nReviewed-by: Alexander Aprelev \nReviewed-by: Siva Annamalai \nCommit-Queue: Ryan Macnak ","shortMessageHtmlLink":"[test_runner] Reduce timeouts."}},{"before":"adfbcc7657248be8a64ad1313c15f7a58cf15e23","after":"f02007839d2268da89e83891b377c48f3ee8fcac","ref":"refs/heads/main","pushedAt":"2024-04-26T21:40:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[test_runner] Reduce timeouts.\n\nWe've roughly doubled bot speeds; half timeouts to provide pressure against this simply getting filled with slower tests.\n\nChange-Id: I812da7adc6c08e6d484732c2558e0d3f63b2694a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364385\nReviewed-by: Alexander Aprelev \nReviewed-by: Siva Annamalai \nCommit-Queue: Ryan Macnak ","shortMessageHtmlLink":"[test_runner] Reduce timeouts."}},{"before":"4c888ab54cfb6be257351a225c9d157b12cfe692","after":"adfbcc7657248be8a64ad1313c15f7a58cf15e23","ref":"refs/heads/master","pushedAt":"2024-04-26T21:32:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Update DevTools rev to e15c47243362b160646f03df9b1ad8d41e9a2d30\n\nChange-Id: I8def4dca26b200a9f03cfbd2ef8e66edb0f6bac3\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364621\nReviewed-by: Ben Konyi \nCommit-Queue: Kenzie Davisson ","shortMessageHtmlLink":"Update DevTools rev to e15c47243362b160646f03df9b1ad8d41e9a2d30"}},{"before":"4c888ab54cfb6be257351a225c9d157b12cfe692","after":"adfbcc7657248be8a64ad1313c15f7a58cf15e23","ref":"refs/heads/main","pushedAt":"2024-04-26T21:32:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Update DevTools rev to e15c47243362b160646f03df9b1ad8d41e9a2d30\n\nChange-Id: I8def4dca26b200a9f03cfbd2ef8e66edb0f6bac3\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364621\nReviewed-by: Ben Konyi \nCommit-Queue: Kenzie Davisson ","shortMessageHtmlLink":"Update DevTools rev to e15c47243362b160646f03df9b1ad8d41e9a2d30"}},{"before":"15c3434efec1d954e5d0176713538872236e3551","after":"4c888ab54cfb6be257351a225c9d157b12cfe692","ref":"refs/heads/master","pushedAt":"2024-04-26T20:45:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"linter: do not report use_is_even in const situations\n\nFixes https://github.com/dart-lang/linter/issues/4915\n\nChange-Id: I4b353b3f8cc064d15bbe366c9008c9a2fc1e1144\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364620\nCommit-Queue: Phil Quitslund \nReviewed-by: Phil Quitslund \nAuto-Submit: Samuel Rawlins ","shortMessageHtmlLink":"linter: do not report use_is_even in const situations"}},{"before":"15c3434efec1d954e5d0176713538872236e3551","after":"4c888ab54cfb6be257351a225c9d157b12cfe692","ref":"refs/heads/main","pushedAt":"2024-04-26T20:45:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"linter: do not report use_is_even in const situations\n\nFixes https://github.com/dart-lang/linter/issues/4915\n\nChange-Id: I4b353b3f8cc064d15bbe366c9008c9a2fc1e1144\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364620\nCommit-Queue: Phil Quitslund \nReviewed-by: Phil Quitslund \nAuto-Submit: Samuel Rawlins ","shortMessageHtmlLink":"linter: do not report use_is_even in const situations"}},{"before":"4432585051215678b25576f0c959371bdc315dd3","after":"15c3434efec1d954e5d0176713538872236e3551","ref":"refs/heads/master","pushedAt":"2024-04-26T20:09:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Completion. Issue 55576. Support for completion in IndexExpression.\n\nBug: https://github.com/dart-lang/sdk/issues/55576\nChange-Id: I30369fa9259e6852204acd8ad2d130617f2b8e12\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364581\nCommit-Queue: Konstantin Shcheglov \nReviewed-by: Phil Quitslund ","shortMessageHtmlLink":"Completion. Issue 55576. Support for completion in IndexExpression."}},{"before":"4432585051215678b25576f0c959371bdc315dd3","after":"15c3434efec1d954e5d0176713538872236e3551","ref":"refs/heads/main","pushedAt":"2024-04-26T20:09:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Completion. Issue 55576. Support for completion in IndexExpression.\n\nBug: https://github.com/dart-lang/sdk/issues/55576\nChange-Id: I30369fa9259e6852204acd8ad2d130617f2b8e12\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364581\nCommit-Queue: Konstantin Shcheglov \nReviewed-by: Phil Quitslund ","shortMessageHtmlLink":"Completion. Issue 55576. Support for completion in IndexExpression."}},{"before":"919c7cab870b714dd674cf20c27d65a7b2e07ffc","after":"7173b4dd01632e85d8119e418b82acf35c411d90","ref":"refs/heads/dev","pushedAt":"2024-04-26T20:04:13.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Version 3.5.0-106.0.dev\n\nMerge 307d7391588ec54bada9161339f5440ead0e6a69 into dev","shortMessageHtmlLink":"Version 3.5.0-106.0.dev"}},{"before":"307d7391588ec54bada9161339f5440ead0e6a69","after":"4432585051215678b25576f0c959371bdc315dd3","ref":"refs/heads/master","pushedAt":"2024-04-26T19:27:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Augment. Store 'augmentationTargetAny', check type in 'augmentationTarget'.\n\nSo, we can distinguish \"no target\" from \"invalid target\".\n\nIf we augment a setter, and there is no target, we also probe getters\n(and methods, constructors). Which theoretically is not the same as\naugmenting e.g. a class with a mixin - they live in different names.\nNot sure. Maybe don't look for `name` when `name=`?\nThe difference is that we will report \"No augmentation target\" vs\n\"It is wrong when a setter augments a method\".\n\nChange-Id: Ibee84b2d039cf16824cb367fefdcda72b99f54bf\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364603\nCommit-Queue: Konstantin Shcheglov \nReviewed-by: Phil Quitslund ","shortMessageHtmlLink":"Augment. Store 'augmentationTargetAny', check type in 'augmentationTa…"}},{"before":"307d7391588ec54bada9161339f5440ead0e6a69","after":"4432585051215678b25576f0c959371bdc315dd3","ref":"refs/heads/main","pushedAt":"2024-04-26T19:27:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Augment. Store 'augmentationTargetAny', check type in 'augmentationTarget'.\n\nSo, we can distinguish \"no target\" from \"invalid target\".\n\nIf we augment a setter, and there is no target, we also probe getters\n(and methods, constructors). Which theoretically is not the same as\naugmenting e.g. a class with a mixin - they live in different names.\nNot sure. Maybe don't look for `name` when `name=`?\nThe difference is that we will report \"No augmentation target\" vs\n\"It is wrong when a setter augments a method\".\n\nChange-Id: Ibee84b2d039cf16824cb367fefdcda72b99f54bf\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364603\nCommit-Queue: Konstantin Shcheglov \nReviewed-by: Phil Quitslund ","shortMessageHtmlLink":"Augment. Store 'augmentationTargetAny', check type in 'augmentationTa…"}},{"before":"b464fc9037e670e11171c1aa3e739fcdf49e9cdc","after":"307d7391588ec54bada9161339f5440ead0e6a69","ref":"refs/heads/master","pushedAt":"2024-04-26T19:10:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[dart:js_interop] Fix lowerings of ExternalDartReferences\n\nCloses https://github.com/dart-lang/sdk/issues/55549\nCloses https://github.com/dart-lang/sdk/issues/55340\n\nFixes several issues around using ExternalDartReferences:\n- Better inlining of interop methods is enabled when this\ntype is used. This also indirectly improves inlining when\nusing JSAny.\n- Adding some missed inlining for setting properties in\ngeneral.\n- Allows opaque references of Dart functions to be passed\nto JS\n- Allows type parameters that extend ExternalDartReference\nto be used in interop methods.\n- Fixes up parent pointers of nodes in transforms.\n\nChange-Id: I8cbd163ee3c1b98e733c35a61e6e83a0787d334c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364580\nReviewed-by: Sigmund Cherem \nCommit-Queue: Srujan Gaddam ","shortMessageHtmlLink":"[dart:js_interop] Fix lowerings of ExternalDartReferences"}},{"before":"b464fc9037e670e11171c1aa3e739fcdf49e9cdc","after":"307d7391588ec54bada9161339f5440ead0e6a69","ref":"refs/heads/main","pushedAt":"2024-04-26T19:10:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[dart:js_interop] Fix lowerings of ExternalDartReferences\n\nCloses https://github.com/dart-lang/sdk/issues/55549\nCloses https://github.com/dart-lang/sdk/issues/55340\n\nFixes several issues around using ExternalDartReferences:\n- Better inlining of interop methods is enabled when this\ntype is used. This also indirectly improves inlining when\nusing JSAny.\n- Adding some missed inlining for setting properties in\ngeneral.\n- Allows opaque references of Dart functions to be passed\nto JS\n- Allows type parameters that extend ExternalDartReference\nto be used in interop methods.\n- Fixes up parent pointers of nodes in transforms.\n\nChange-Id: I8cbd163ee3c1b98e733c35a61e6e83a0787d334c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364580\nReviewed-by: Sigmund Cherem \nCommit-Queue: Srujan Gaddam ","shortMessageHtmlLink":"[dart:js_interop] Fix lowerings of ExternalDartReferences"}},{"before":"9936bafe5eb1e10a7de10576ed8265f18389d894","after":"919c7cab870b714dd674cf20c27d65a7b2e07ffc","ref":"refs/heads/dev","pushedAt":"2024-04-26T16:04:54.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Version 3.5.0-105.0.dev\n\nMerge 54031e2752d76a95fa7fa069bf1b41a21260b5e9 into dev","shortMessageHtmlLink":"Version 3.5.0-105.0.dev"}},{"before":"94890c86c7d2e6fa029ed735b366d2b05be4de86","after":"b464fc9037e670e11171c1aa3e739fcdf49e9cdc","ref":"refs/heads/master","pushedAt":"2024-04-26T15:29:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Reland \"Tweak `expect.dart` library.\"\n\nThis reverts commit cd2c566bcf2263e93bef877443a784f3afe35549.\n\nReason for revert: Updating to not remove field used by Flutter engine.\n\nOriginal change's description:\n> Revert \"Tweak `expect.dart` library.\"\n>\n> This reverts commit ff5f391c0a0247f449a959797ecf6e10ba950da2.\n>\n> Reason for revert: The expect library is used by Flutter engine, and some of its tests use assertStatementsEnabled. There should be a migration path that doesn't require an atomic change, like adding the replacement api before removing the old one.\n>\n> Original change's description:\n> > Tweak `expect.dart` library.\n> >\n> > Make API more consistent for a few methods.\n> > Reduce the number of language features used in tests:\n> > * Never iterating an iterable, always converting it\n> > using `.toList()` first and iterating using indices\n> > (fx `setEquals`).\n> > Also require a `List` in places where an `Iterable`\n> > wasn't necessary.\n> > * Avoid doing complicated computations that are also\n> > used for the error message. Do simple check first,\n> > then recompute to get better error messages\n> > (fx `allDistinct`).\n> >\n> > Renamed some rarely used members for consistency\n> > (`stringContainsInOrder`->`containsInOrder`,\n> > where other string-contains functions just start\n> > with `contains`, and `containsOneOf` -> `containsAny`\n> > to match `Iterable.any` phrasing, and also it accepts\n> > if containing at least one, not precisely one.)\n> >\n> > Removed a function that wasn't used anywhere.\n> >\n> > Moved `assertStatementsEnabled` to `variations.dart` as `asserts`.\n> > Removed `typeAssertionsEnabled` and `checkedModeEnabled`. The former used in one place, where it was replaced with `checkedImplicitDowncasts` from `variations.dart`, the latter wasn't used anywhere.\n> >\n> > Deprecates `package:expect/minitest.dart`. It was never intended\n> > to be used for new tests, only as a help to convert existing tests\n> > written against `package:unit_test`.\n> > All existing imports marked as `// ignore: deprecated_member_use`.\n> >\n> > Change-Id: I07e21d4c0f3ccf11b82ee34af2668fdbb22264d2\n> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352360\n> > Reviewed-by: Slava Egorov \n> > Reviewed-by: Ömer Ağacan \n> > Reviewed-by: Nate Bosch \n> > Reviewed-by: Stephen Adams \n> > Commit-Queue: Lasse Nielsen \n>\n> Change-Id: I360b4347470a0bb2b63c3108e2b83ee2a771bf3f\n> No-Presubmit: true\n> No-Tree-Checks: true\n> No-Try: true\n> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362020\n> Reviewed-by: Nate Bosch \n> Reviewed-by: Ömer Ağacan \n> Reviewed-by: Stephen Adams \n> Reviewed-by: Leaf Petersen \n> Bot-Commit: Rubber Stamper \n> Commit-Queue: William Hesse \n\nCoreLibraryReviewExempt: Reland\nChange-Id: I53db40edc0733842a008839c3913d51c885e39ab\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/362502\nReviewed-by: Alexander Thomas \nReviewed-by: Nate Bosch \nReviewed-by: Ömer Ağacan \nReviewed-by: Slava Egorov \nReviewed-by: William Hesse \nCommit-Queue: Lasse Nielsen ","shortMessageHtmlLink":"Reland \"Tweak expect.dart library.\""}},{"before":"94890c86c7d2e6fa029ed735b366d2b05be4de86","after":"b464fc9037e670e11171c1aa3e739fcdf49e9cdc","ref":"refs/heads/main","pushedAt":"2024-04-26T15:29:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Reland \"Tweak `expect.dart` library.\"\n\nThis reverts commit cd2c566bcf2263e93bef877443a784f3afe35549.\n\nReason for revert: Updating to not remove field used by Flutter engine.\n\nOriginal change's description:\n> Revert \"Tweak `expect.dart` library.\"\n>\n> This reverts commit ff5f391c0a0247f449a959797ecf6e10ba950da2.\n>\n> Reason for revert: The expect library is used by Flutter engine, and some of its tests use assertStatementsEnabled. There should be a migration path that doesn't require an atomic change, like adding the replacement api before removing the old one.\n>\n> Original change's description:\n> > Tweak `expect.dart` library.\n> >\n> > Make API more consistent for a few methods.\n> > Reduce the number of language features used in tests:\n> > * Never iterating an iterable, always converting it\n> > using `.toList()` first and iterating using indices\n> > (fx `setEquals`).\n> > Also require a `List` in places where an `Iterable`\n> > wasn't necessary.\n> > * Avoid doing complicated computations that are also\n> > used for the error message. Do simple check first,\n> > then recompute to get better error messages\n> > (fx `allDistinct`).\n> >\n> > Renamed some rarely used members for consistency\n> > (`stringContainsInOrder`->`containsInOrder`,\n> > where other string-contains functions just start\n> > with `contains`, and `containsOneOf` -> `containsAny`\n> > to match `Iterable.any` phrasing, and also it accepts\n> > if containing at least one, not precisely one.)\n> >\n> > Removed a function that wasn't used anywhere.\n> >\n> > Moved `assertStatementsEnabled` to `variations.dart` as `asserts`.\n> > Removed `typeAssertionsEnabled` and `checkedModeEnabled`. The former used in one place, where it was replaced with `checkedImplicitDowncasts` from `variations.dart`, the latter wasn't used anywhere.\n> >\n> > Deprecates `package:expect/minitest.dart`. It was never intended\n> > to be used for new tests, only as a help to convert existing tests\n> > written against `package:unit_test`.\n> > All existing imports marked as `// ignore: deprecated_member_use`.\n> >\n> > Change-Id: I07e21d4c0f3ccf11b82ee34af2668fdbb22264d2\n> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352360\n> > Reviewed-by: Slava Egorov \n> > Reviewed-by: Ömer Ağacan \n> > Reviewed-by: Nate Bosch \n> > Reviewed-by: Stephen Adams \n> > Commit-Queue: Lasse Nielsen \n>\n> Change-Id: I360b4347470a0bb2b63c3108e2b83ee2a771bf3f\n> No-Presubmit: true\n> No-Tree-Checks: true\n> No-Try: true\n> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362020\n> Reviewed-by: Nate Bosch \n> Reviewed-by: Ömer Ağacan \n> Reviewed-by: Stephen Adams \n> Reviewed-by: Leaf Petersen \n> Bot-Commit: Rubber Stamper \n> Commit-Queue: William Hesse \n\nCoreLibraryReviewExempt: Reland\nChange-Id: I53db40edc0733842a008839c3913d51c885e39ab\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/362502\nReviewed-by: Alexander Thomas \nReviewed-by: Nate Bosch \nReviewed-by: Ömer Ağacan \nReviewed-by: Slava Egorov \nReviewed-by: William Hesse \nCommit-Queue: Lasse Nielsen ","shortMessageHtmlLink":"Reland \"Tweak expect.dart library.\""}},{"before":"54031e2752d76a95fa7fa069bf1b41a21260b5e9","after":"94890c86c7d2e6fa029ed735b366d2b05be4de86","ref":"refs/heads/master","pushedAt":"2024-04-26T14:51:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[vm] Resource Identifier fix loading units\n\nThe loading units were taken from the definitions instead of the\nreferences.\nThis CL fixes that and adds test cases.\n\nAdd some doc comments and references to TODOs.\n\nTEST=pkg/vm/test/transformations/resource_identifier_test.dart\n\nChange-Id: I59a640344206555ae1b190521ee3e36d52199700\nCq-Include-Trybots: dart/try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-mac-release-try,pkg-mac-release-arm64-try,pkg-win-release-try,pkg-win-release-arm64-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364103\nCommit-Queue: Daco Harkes \nReviewed-by: Moritz Sümmermann ","shortMessageHtmlLink":"[vm] Resource Identifier fix loading units"}},{"before":"54031e2752d76a95fa7fa069bf1b41a21260b5e9","after":"94890c86c7d2e6fa029ed735b366d2b05be4de86","ref":"refs/heads/main","pushedAt":"2024-04-26T14:51:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[vm] Resource Identifier fix loading units\n\nThe loading units were taken from the definitions instead of the\nreferences.\nThis CL fixes that and adds test cases.\n\nAdd some doc comments and references to TODOs.\n\nTEST=pkg/vm/test/transformations/resource_identifier_test.dart\n\nChange-Id: I59a640344206555ae1b190521ee3e36d52199700\nCq-Include-Trybots: dart/try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-mac-release-try,pkg-mac-release-arm64-try,pkg-win-release-try,pkg-win-release-arm64-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364103\nCommit-Queue: Daco Harkes \nReviewed-by: Moritz Sümmermann ","shortMessageHtmlLink":"[vm] Resource Identifier fix loading units"}},{"before":"c11d54ec31f06fec07ef8f5d7fd7809546aac9f1","after":"a8df3c4facd924b93413cb3a8cc88e2415fdfc11","ref":"refs/heads/beta","pushedAt":"2024-04-26T14:19:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[beta] [tfa] Fix crash when building field guard summary with captured receiver\n\nWhen building a field guard summary, field initializer is not included\ninto the body. So field initializer AST should not be visited to\ncalculate captured variables and field guard summary\nshould not have a captured reveiver.\n\nTEST=pkg/vm/testcases/transformations/type_flow/transformer/regress_flutter147239.dart\n\nIssue: https://github.com/flutter/flutter/issues/147239\nChange-Id: Ibb4827edcfb253c13ac40e6167a447ad36d9eb5e\nCherry-pick: https://dart-review.googlesource.com/c/sdk/+/364203\nCherry-pick-request: https://github.com/dart-lang/sdk/issues/55557\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364380\nCommit-Queue: Alexander Markov \nReviewed-by: Siva Annamalai ","shortMessageHtmlLink":"[beta] [tfa] Fix crash when building field guard summary with capture…"}},{"before":"dd3fbffac7ac302a4aed3c033d96dfaf204d54d4","after":"54031e2752d76a95fa7fa069bf1b41a21260b5e9","ref":"refs/heads/master","pushedAt":"2024-04-26T14:07:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[cfe] Ensure default values in synthesized function nodes\n\nCloses https://github.com/dart-lang/sdk/issues/55529\n\nChange-Id: Ic4738e9b8abc333a39ec52b642bbf844128ef61b\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364325\nCommit-Queue: Chloe Stefantsova \nReviewed-by: Johnni Winther \nAuto-Submit: Chloe Stefantsova ","shortMessageHtmlLink":"[cfe] Ensure default values in synthesized function nodes"}},{"before":"dd3fbffac7ac302a4aed3c033d96dfaf204d54d4","after":"54031e2752d76a95fa7fa069bf1b41a21260b5e9","ref":"refs/heads/main","pushedAt":"2024-04-26T14:07:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"[cfe] Ensure default values in synthesized function nodes\n\nCloses https://github.com/dart-lang/sdk/issues/55529\n\nChange-Id: Ic4738e9b8abc333a39ec52b642bbf844128ef61b\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/364325\nCommit-Queue: Chloe Stefantsova \nReviewed-by: Johnni Winther \nAuto-Submit: Chloe Stefantsova ","shortMessageHtmlLink":"[cfe] Ensure default values in synthesized function nodes"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEO_kaMQA","startCursor":null,"endCursor":null}},"title":"Activity · dart-lang/sdk"}